Conversation
initial commit update vale update placement update auth
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ezgidemirel
left a comment
ezgidemirel
left a comment
There was a problem hiding this comment.
Thanks @tr0njavolta, this looks great! I left a couple of comments, but it explains the flow very clearly.
| EOF | ||
| ``` | ||
|
|
||
| ## Configure Vault Kubernetes auth |
There was a problem hiding this comment.
I wouldn't include this section to the doc. They may prefer different authentication methods based on their environments. We can simply say, token based authentication and kubernetes authentication are supported.
If they already have a Vault instance, they new how they can authenticate to it.
There was a problem hiding this comment.
Remove this section completely or just add a step like "Configuration Vault authentication in your preferred method" ?
There was a problem hiding this comment.
We can remove the whole section since they don’t need to use Kubernetes auth. Instead, we can add a short paragraph before the StoreConfig resource creation that mentions the available authentication methods for Vault.
3 participants
Description
Type of change
Checklist
make vale-file FILE=docs/path/to/file.mdlocally for files changed (or will fix Vale suggestions in review)Additional notes