Support nanosecond-precision timestamps#1634
Merged
tstack merged 2 commits intotstack:masterfrom Mar 2, 2026
Merged
Conversation
Yukigaru
force-pushed
the
fix-nanosecond-parsing
branch
3 times, most recently
from
8ea66dd to
3f0b550
Compare
Yukigaru
force-pushed
the
fix-nanosecond-parsing
branch
from
3f0b550 to
9119ff8
Compare
Owner
|
Looks good and thanks for including a test! Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At job we use nanosecond precision timestamps:
But lnav doesn't support them, which leads to:
:goto <timestamp>doesn't work)The root cause is the generic_log format regex expects only up to 6 digits (\d{1,6}) instead of possible 9.
Fix tested.
Tests run exactly as in master (3 fails, not connected to this change).
Example file: bug_nanos.log