Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
When comparing multiple runs across different models (e.g., training 5 models 10 times each), I often use the “Color runs by regex” feature.
This change adds the ability to manually assign colors to each regex group.
Technical description of changes
Screenshots of UI changes
Setting the regex
Selecting group color
After clicking Save
Detailed steps to verify changes work correctly (as executed by you)
groupAandgroupBas shown in the screenshots).(A|B)to create the groups.Alternate designs / implementations considered (or N/A)
My Angular experience is limited, so the implementation follows the existing approach used for
onRunColorChange.The colors are currently applied within the
runGroupByChangedaction.If there is a more appropriate pattern for handling this, suggestions are welcome and I can update the implementation.
Tests can also be added if needed.