💥 Unify SimplePlugin interceptors into single parameter#1328
Open
tconley1428 wants to merge 1 commit intomainfrom
Open
💥 Unify SimplePlugin interceptors into single parameter#1328tconley1428 wants to merge 1 commit intomainfrom
tconley1428 wants to merge 1 commit intomainfrom
Conversation
BREAKING CHANGE: SimplePlugin constructor now takes a single `interceptors` parameter instead of separate `client_interceptors` and `worker_interceptors` parameters.
Changes:
- Replace `client_interceptors` and `worker_interceptors` with unified `interceptors` parameter
- Automatically separate client and worker interceptors based on type
- Ensure exactly one instance of each interceptor per worker to prevent duplication
- Update OpenTelemetryPlugin and OpenAIAgentsPlugin to use new parameter
- Update all tests to use new unified parameter
Migration guide for SimplePlugin users:
- Before: `SimplePlugin("name", client_interceptors=[...], worker_interceptors=[...])`
- After: `SimplePlugin("name", interceptors=[...])`
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client_interceptorsandworker_interceptorsparameters with a single unifiedinterceptorsparameter inSimplePluginBreaking Changes
For SimplePlugin Users
Before:
After:
The plugin will automatically:
Implementation Details
configure_client()to filter unified interceptors to client-only typesconfigure_worker()to filter unified interceptors to worker types and prevent duplication with client-registered interceptorsconfigure_replayer()to use worker interceptors from unified listTest Coverage
🤖 Generated with Claude Code