You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i found that the ruling find intersection method doesn't give me all the intersections, so after investigating the problem in found that is because of the comparator in the tree on the ruling, it compare just the top/y so that lead to remove any ruling have the same top/y.
so it's better to use the hashcode of the object as the key an the object it self as the value, this fixed the problem for me.
I spoke with @zanninso via email. We discussed that we didn't originally intend for findIntersections() to be called without first calling collapseOrientedRulings, which should fix this problem (by guaranteeing that there are no overlapping lines with the same orientation).
I don't, however, recall why the TreeMap using Ruling.top() as the comparator, rather than the hashcode (as proposed in this PR). It seems either might work and the suggestion might be simpler. @jazzido do you recall?
hello
The problem that we discussed before it just happened in the unexcepted way, even following the process and call "collapseOrientedRulings()" before calling "findIntersections()" , it's harder to get the case where it happens, but i will try to investigate when i get some free time and i will send it to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i found that the ruling find intersection method doesn't give me all the intersections, so after investigating the problem in found that is because of the comparator in the tree on the ruling, it compare just the top/y so that lead to remove any ruling have the same top/y.
so it's better to use the hashcode of the object as the key an the object it self as the value, this fixed the problem for me.