Open
Conversation
Author
|
... so after a couple hours of debugging I just realized that this happens because the line returns used by tabula-java are carriage returns instead of line feeds, which means the beginning of the line is overwritten, and it actually works just fine. I've added a test as well and think this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #21.
I've never worked with PDFBox before, so I hope this is the right approach -- it works at least for this file (without the color filter, some of the underlines for the hyperlinks are detected as rulings, which splits those rows). However, it doesn't work for this file (without the color filter, it simply detects all cells as separate). With the color filter, it exports the following CSV:
Is this an issue with the color filter or is it related to the red and black lines crossing?
Other notes:
ObjectExtractorStreamEngine.