Fall back to X/Twitter photo for guests without GitHub#2183
Open
2u841r wants to merge 3 commits intosyntaxfm:mainfrom
Open
Fall back to X/Twitter photo for guests without GitHub#21832u841r wants to merge 3 commits intosyntaxfm:mainfrom
2u841r wants to merge 3 commits intosyntaxfm:mainfrom
Conversation
Guests with no GitHub handle were showing a broken image. Falls back to unavatar.io/twitter for guests with a Twitter handle, and github.com/ghost.png for the rare case of neither. Closes syntaxfm#2182 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@2u841r is attempting to deploy a commit to the Syntax Team on Vercel. A member of the Team first needs to authorize it. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- guest/[name_slug]: fix broken github.com/null.png (e.g. Dr. Courtney Tolinski) - FacePile: add twitter fallback so ShowCard faces on shows/ page also benefit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/null.png)unavatar.io/twitter/{handle}for guests who have a Twitter/X accountgithub.com/ghost.pngfor the 2 guests with neither (Loïc Houssier, Anna Poblets)Fixes 12 guests with missing photos — 10 will now show their X profile photo.
Changes
src/routes/(site)/guests/+page.server.ts— addtwitterto the guest selectsrc/routes/(site)/guests/+page.svelte— update<img src>to use fallback chainCloses #2182
🤖 Generated with Claude Code