Skip to content

fix(kafka): resolves kafka connect catalog failure#89

Merged
freeznet merged 2 commits intomainfrom
freeznet/fix-kafka-connect
Apr 3, 2026
Merged

fix(kafka): resolves kafka connect catalog failure#89
freeznet merged 2 commits intomainfrom
freeznet/fix-kafka-connect

Conversation

@freeznet
Copy link
Copy Markdown
Member

@freeznet freeznet commented Apr 3, 2026

No description provided.

@freeznet freeznet self-assigned this Apr 3, 2026
@freeznet freeznet requested a review from a team as a code owner April 3, 2026 08:16
@freeznet freeznet requested a review from Copilot April 3, 2026 08:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the in-repo Kafka Connect SDK and its OpenAPI spec to reflect the /admin/kafkaconnect base path and expanded/updated endpoint/model definitions, and adjusts the Kafka Connect wrapper to match the regenerated client method signatures.

Changes:

  • Regenerated sdk/sdk-kafkaconnect OpenAPI client (new models like ErrorMessage, Message, WorkerStatus, offsets types; updated endpoint responses; new :pause/:resume/:restart/:stop variants).
  • Updated pkg/kafka/kafkaconnect.go to match regenerated SDK return signatures and manually parse a few response bodies.
  • Updated SDK README/import path and refreshed AGENTS.md repository guidance.

Reviewed changes

Copilot reviewed 55 out of 58 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/sdk-kafkaconnect/api/openapi.yaml New/updated OpenAPI spec including server base path and revised responses/models.
sdk/sdk-kafkaconnect/kafka-connect-admin.json JSON form of the spec updated similarly (responses, schemas, extra endpoints).
sdk/sdk-kafkaconnect/configuration.go Default server URL updated to /admin/kafkaconnect.
sdk/sdk-kafkaconnect/client.go Generated client updates; currently includes non-gofmt formatting changes.
sdk/sdk-kafkaconnect/model_*.go + docs/*.md New/updated generated models and docs for the updated API.
sdk/sdk-kafkaconnect/go.mod + go.sum SDK module metadata updated (module path changed).
pkg/kafka/kafkaconnect.go Wrapper adjusted to new SDK signatures and response parsing.
sdk/sdk-kafkaconnect/README.md Updated import path + base URI documentation.
AGENTS.md Updated agent guidance / repo map and workflows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jiangpengcheng
jiangpengcheng previously approved these changes Apr 3, 2026
@freeznet freeznet merged commit a43ce3c into main Apr 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants