fix(kafka): resolves kafka connect catalog failure#89
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the in-repo Kafka Connect SDK and its OpenAPI spec to reflect the /admin/kafkaconnect base path and expanded/updated endpoint/model definitions, and adjusts the Kafka Connect wrapper to match the regenerated client method signatures.
Changes:
- Regenerated
sdk/sdk-kafkaconnectOpenAPI client (new models likeErrorMessage,Message,WorkerStatus, offsets types; updated endpoint responses; new:pause/:resume/:restart/:stopvariants). - Updated
pkg/kafka/kafkaconnect.goto match regenerated SDK return signatures and manually parse a few response bodies. - Updated SDK README/import path and refreshed
AGENTS.mdrepository guidance.
Reviewed changes
Copilot reviewed 55 out of 58 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/sdk-kafkaconnect/api/openapi.yaml |
New/updated OpenAPI spec including server base path and revised responses/models. |
sdk/sdk-kafkaconnect/kafka-connect-admin.json |
JSON form of the spec updated similarly (responses, schemas, extra endpoints). |
sdk/sdk-kafkaconnect/configuration.go |
Default server URL updated to /admin/kafkaconnect. |
sdk/sdk-kafkaconnect/client.go |
Generated client updates; currently includes non-gofmt formatting changes. |
sdk/sdk-kafkaconnect/model_*.go + docs/*.md |
New/updated generated models and docs for the updated API. |
sdk/sdk-kafkaconnect/go.mod + go.sum |
SDK module metadata updated (module path changed). |
pkg/kafka/kafkaconnect.go |
Wrapper adjusted to new SDK signatures and response parsing. |
sdk/sdk-kafkaconnect/README.md |
Updated import path + base URI documentation. |
AGENTS.md |
Updated agent guidance / repo map and workflows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiangpengcheng
previously approved these changes
Apr 3, 2026
jiangpengcheng
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.