Fix: addresses implicit nullability for PHP 8.4 compatibility#20
Merged
JasonTheAdams merged 2 commits intodevelopfrom Jun 16, 2025
Merged
Fix: addresses implicit nullability for PHP 8.4 compatibility#20JasonTheAdams merged 2 commits intodevelopfrom
JasonTheAdams merged 2 commits intodevelopfrom
Conversation
jonwaldstein
approved these changes
Jun 14, 2025
Contributor
jonwaldstein
left a comment
jonwaldstein
left a comment
There was a problem hiding this comment.
Awesome, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of PHP 8.4 parameters cannot be implicitly nullable. This addresses that by explicitly making said parameters nullable. Note that this is technically not a breaking signature change since any 3rd party code implementing the
ValidationRuleinterface is covariant on the parameter.