Skip to content

TypeScript Rewrite: Version Conflict Check#52

Open
d4mation wants to merge 12 commits intoENG-219/command-checkfrom
ENG-219/command-check-version-conflict
Open

TypeScript Rewrite: Version Conflict Check#52
d4mation wants to merge 12 commits intoENG-219/command-checkfrom
ENG-219/command-check-version-conflict

Conversation

@d4mation
Copy link
Contributor

@d4mation d4mation commented Feb 12, 2026

🎫 ENG-219

Summary

  • Adds the built-in version-conflict check that verifies all configured version files contain the same version number
  • File existence validation before running the check
  • Normalized version comparison (trims beyond 3 segments)
  • Registers check:version-conflict subcommand (available even when not configured in .puprc)

Dependencies

Test plan

  • Automated tests pass (bun run test)
  • bun run build succeeds
  • bun run lint passes
  • bun run typecheck passes
  • Configure multiple version files in .puprc paths.versions with matching versions and verify bunx pup check reports no conflicts
  • Configure version files with mismatched versions and verify the check fails with a red "Found more than one version" message
  • Run bunx pup check:version-conflict and verify it runs standalone without the [version-conflict] prefix
  • Run bunx pup check:version-conflict when version-conflict is not in .puprc checks and verify it still runs (built-in always registered)
  • Point a version file to a non-existent file and verify it shows a plain ERROR: Version file does not exist message

Adds the built-in version-conflict check that verifies all configured
version files contain the same version number, with file existence
validation and normalized version comparison.
@d4mation d4mation marked this pull request as ready for review February 12, 2026 21:00
@d4mation d4mation added the On Hold We're waiting for something. The Pull Request should not be merged. label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Hold We're waiting for something. The Pull Request should not be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant