[6.x] Fix nested Bard field focus in Firefox #13853
Open
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o1y
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13852
ProseMirror automatically sets
contenteditable="false"on the node view wrappers that don't have acontentDOM, which nicludes Bard Sets. In Firefox this prevents nestedcontenteditable="true"elements from receiving focus on click.This work around pre-sets
contenteditable="true"on the<node-view-wrapper>. This seems to cause Firefox to inconsistently handle the drag handle, sometimes handling the drag and sometimes showing a text cursor next to the drag handle instead. ThehandleDragmethod works around this by temporarily togglingcontenteditabletofalseduring drag operations.Would be good to properly test this fix though :)