Remove seemingly outdated lme4 note#558
Merged
aloctavodia merged 1 commit intostan-dev:masterfrom Mar 12, 2026
Merged
Conversation
Collaborator
|
Thanks. I am merging this as the failing tests are unrelated to the PR. |
aloctavodia
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a note concerning
lme4::mkNewReTrms()'s argumentre.formwhose behavior seems to have been changed (fixed) in lme4 v1.1-38 (in that version,re.form <- re.form %||% reOnly(formula(object))was added at the beginning oflme4::mkNewReTrms()). For now, I am not changing the call tolme4::mkNewReTrms()which is directly underneath that note because users might have an older version of lme4 installed and because adapting this call to the installed lme4 version would be overkill (the current call continues to work independent of the lme4 version because we don't rely onre.form = NULLbut specifyre.formexplicitly).Btw,
R CMD checkcurrently says:which is probably due to commit 6e0682d (PR #556). I guess that needs to be fixed before a new CRAN release.