Skip to content

Remove seemingly outdated lme4 note#558

Merged
aloctavodia merged 1 commit intostan-dev:masterfrom
fweber144:update_lme4_note
Mar 12, 2026
Merged

Remove seemingly outdated lme4 note#558
aloctavodia merged 1 commit intostan-dev:masterfrom
fweber144:update_lme4_note

Conversation

@fweber144
Copy link
Collaborator

This removes a note concerning lme4::mkNewReTrms()'s argument re.form whose behavior seems to have been changed (fixed) in lme4 v1.1-38 (in that version, re.form <- re.form %||% reOnly(formula(object)) was added at the beginning of lme4::mkNewReTrms()). For now, I am not changing the call to lme4::mkNewReTrms() which is directly underneath that note because users might have an older version of lme4 installed and because adapting this call to the installed lme4 version would be overkill (the current call continues to work independent of the lme4 version because we don't rely on re.form = NULL but specify re.form explicitly).

Btw, R CMD check currently says:

checking R code for possible problems [...] NOTE
  plot.vsel: no visible global function definition for ‘packageVersion’
  plot.vsel: no visible binding for global variable ‘fontsize’
  Undefined global functions or variables:
    fontsize packageVersion
  Consider adding
    importFrom("utils", "packageVersion")
  to your NAMESPACE file.

which is probably due to commit 6e0682d (PR #556). I guess that needs to be fixed before a new CRAN release.

@aloctavodia
Copy link
Collaborator

Thanks. I am merging this as the failing tests are unrelated to the PR.

@aloctavodia aloctavodia merged commit 72eb5eb into stan-dev:master Mar 12, 2026
4 of 5 checks passed
@fweber144 fweber144 deleted the update_lme4_note branch March 12, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants