Standardize PPC messages to warn/inform#462
Merged
jgabry merged 6 commits intostan-dev:masterfrom Mar 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 98.55% 98.63% +0.08%
==========================================
Files 35 35
Lines 5864 5863 -1
==========================================
+ Hits 5779 5783 +4
+ Misses 85 80 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
approved these changes
Mar 13, 2026
Member
jgabry
left a comment
There was a problem hiding this comment.
Thanks, looks good. We can merge if all the tests pass.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
|
Don't worry about the copilot suggestions, I don't think they're necessary |
Contributor
Author
|
ohh thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #461
Summary
This PR standardizes user-facing messaging by replacing base
warning()andmessage()calls withrlang::warn()andrlang::inform()in selected PPC code paths.Changes
warning()withrlang::warn()inppc_loo().message()withrlang::inform()inppc_loo().message()withrlang::inform()inppc_censoring().message()withrlang::inform()inppc_test_statistics().The message content and trigger logic remain unchanged.
Why
bayesplotalready usesrlangconditions in several places. Usingwarn()andinform()ensures more consistent condition handling and better interoperability withrlang-based workflows.