STACKITLB-798 | add ALB TF provider#1198
Open
david-mey-STACKIT wants to merge 8 commits intostackitcloud:mainfrom
Open
STACKITLB-798 | add ALB TF provider#1198david-mey-STACKIT wants to merge 8 commits intostackitcloud:mainfrom
david-mey-STACKIT wants to merge 8 commits intostackitcloud:mainfrom
Conversation
Contributor
|
imo we should use |
marceljk
reviewed
Feb 6, 2026
stackit/internal/services/alb/applicationloadbalancer/datasource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/alb/applicationloadbalancer/datasource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/alb/applicationloadbalancer/datasource.go
Outdated
Show resolved
Hide resolved
david-mey-STACKIT
added a commit
to david-mey-STACKIT/terraform-provider-stackit
that referenced
this pull request
Feb 9, 2026
david-mey-STACKIT
force-pushed
the
main
branch
from
7db8e97 to
ac05133
Compare
marceljk
reviewed
Feb 10, 2026
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
Comment on lines
531
to
533
| Validators: []validator.String{ | ||
| stringvalidator.LengthBetween(4, 6), | ||
| }, |
Contributor
There was a problem hiding this comment.
Please remove also the LengthBetween validator. We don't have for any resource a validation of the region and I prefer that we keep this consistent for alb
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
david-mey-STACKIT
force-pushed
the
main
branch
from
eab55b8 to
7dd76db
Compare
marceljk
reviewed
Feb 11, 2026
stackit/internal/services/alb/applicationloadbalancer/resource.go
Outdated
Show resolved
Hide resolved
marceljk
reviewed
Feb 11, 2026
Comment on lines
646
to
648
| // loadbalancer terraform ID: = "[project_id],[name]" | ||
| loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[1] | ||
| loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName) |
Contributor
There was a problem hiding this comment.
wrong structure of the ID
Suggested change
| // loadbalancer terraform ID: = "[project_id],[name]" | |
| loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[1] | |
| loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName) | |
| // loadbalancer terraform ID: = "[project_id],[region],[name]" | |
| loadbalancerName := strings.Split(rs.Primary.ID, core.Separator)[2] | |
| loadbalancersToDestroy = append(loadbalancersToDestroy, loadbalancerName) |
Contributor
|
Please check the failing CI pipeline |
marceljk
reviewed
Feb 11, 2026
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
david-mey-STACKIT
force-pushed
the
main
branch
8 times, most recently
from
edee1ce to
35e0675
Compare
david-mey-STACKIT
force-pushed
the
main
branch
from
35e0675 to
b7bf33e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
STACKITLB-798
Add Application Load Balancer provider (API: https://docs.api.stackit.cloud/documentation/alb/version/v2)
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)