Skip to content

feat: Add STACK and DEMO templating parameters#432

Merged
sbernauer merged 4 commits intomainfrom
feat/template-stack-and-demo
Mar 18, 2026
Merged

feat: Add STACK and DEMO templating parameters#432
sbernauer merged 4 commits intomainfrom
feat/template-stack-and-demo

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 17, 2026

Description

Part of #187

Extracted the STACK and DEMO templating out of #429, as it's the IMHO uncontroversial part. It unblocks us from adapting the demo YAMLs already (stackabletech/demos#374).
Doing so I fixed some problems regarding what to make available when, it now has the same semantics as the existing stack and demo labels. I also document them in the README.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

Co-authored-by: Xenia Fischer<xenia.fischer@stackable.tech>
@sbernauer sbernauer self-assigned this Mar 17, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Mar 17, 2026
@sbernauer sbernauer requested a review from a team March 17, 2026 15:26
NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 18, 2026
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 18, 2026
@sbernauer sbernauer added this pull request to the merge queue Mar 18, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 18, 2026
Merged via the queue into main with commit 2a9d9d5 Mar 18, 2026
22 checks passed
@sbernauer sbernauer deleted the feat/template-stack-and-demo branch March 18, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants