fix: idempotent helm installations for demos/stacks and ignoring of existing jobs#386
Merged
fix: idempotent helm installations for demos/stacks and ignoring of existing jobs#386
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation for #312 and #333
Current procedure to upgrade a demo:
Example output of failed Job updates due to immutability:
Problem encountered during development when running
helm upgrade --installonopensearch-dashboardsThrown for
opensearch-dashboardsHelm Chart, because of opensearch-project/helm-charts#655Should be working due to setting
ChartSpec.Force = trueinrust/helm-sys/go-helm-wrapper/main.gobut does not.Update/Solution: Due to changes in Helm 3 and how the
--forceflag works (helm/helm#7082 (comment)), @NickLarsenNZ and me decided to switch from thehelm upgrade --installto the strategy of uninstalling the old Helm Chart and installing the new one instead for an upgrade.Definition of Done Checklist