fix: Fix compilation failures when not enabling default features#1162
Open
fix: Fix compilation failures when not enabling default features#1162
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Bumping operator-rs in containerdebug
Problem
Some of our crates (notable stackable-operator) produce lot's of compilation errors when being pulled in with no default features, e.g.
produces
error: could not compile stackable-operator (lib) due to 237 previous errorsstackable-telemetry is even worse, as it is broken using default features:
causes
Fix
This PR fixes the stackable-operator and stackable-telemetry by making mandatory features actually mandatory.
I also added pre-commit checks to prevent this from happening again.
With this fix I can now pull in exactly what I need in containerdebug:
Definition of Done Checklist
Author
Reviewer
Acceptance