Fix parser failing on field types that wrap across lines#3535
Merged
oldergod merged 2 commits intosquare:masterfrom Mar 11, 2026
Merged
Fix parser failing on field types that wrap across lines#3535oldergod merged 2 commits intosquare:masterfrom
oldergod merged 2 commits intosquare:masterfrom
Conversation
When a qualified type name in a field declaration was split across lines (e.g. with a leading dot on the continuation line), the parser would stop reading the type at the newline and misinterpret the rest. Now readDataType() peeks ahead after reading a word and continues consuming dot-separated segments across line breaks. Fixes square#3281 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Sorry I missed it earlier: CLA has been signed. |
oldergod
approved these changes
Mar 11, 2026
Member
|
Thank you |
oldergod
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a qualified type name in a field declaration was split across lines (e.g. with a leading dot on the continuation line), the parser would stop reading the type at the newline and misinterpret the rest. Now readDataType() peeks ahead after reading a word and continues consuming dot-separated segments across line breaks.
Fixes #3281
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com