Support @HttpExchange in MvcUriComponentsBuilder#36580
Open
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Open
Support @HttpExchange in MvcUriComponentsBuilder#36580kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Conversation
MvcUriComponentsBuilder now recognizes @HttpExchange and composed annotations such as @GetExchange in addition to @RequestMapping when resolving class- and method-level mappings. This allows controllers that implement @HttpExchange interfaces to use fromController(), fromMethodName(), and fromMethodCall() to build links. Closes spring-projectsgh-36235 Signed-off-by: Daeho Kwon <trewq231@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
DhruvTheDev1
reviewed
Apr 1, 2026
Contributor
There was a problem hiding this comment.
Nice fix! Using AnnotatedElementUtils here seems right to make sure it picks up on the httpExchange mappings when they're defined on the parents interface which is how the docs suggest using them. Nice testing too especially on the PersonHttpExchangeControllerImpl to verify the inheritance works as expected. Also nice on updating the error message to include httpExchange which will save time debugging.
DhruvTheDev1
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MvcUriComponentsBuilder now recognizes
@HttpExchangeand composedannotations such as
@GetExchangein addition to@RequestMappingwhen resolving class- and method-level mappings.
This allows controllers that implement
@HttpExchangeinterfaces to usefromController(),fromMethodName(), andfromMethodCall()to build links.Closes gh-36235