Skip to content

Comments

fix(v2): re-deprecate h3 v1 syntax in createMiddleware#2082

Open
birkskyum wants to merge 5 commits intosolidjs:mainfrom
birkskyum:deprecate-h3-v1-syntax-in-createMiddleware
Open

fix(v2): re-deprecate h3 v1 syntax in createMiddleware#2082
birkskyum wants to merge 5 commits intosolidjs:mainfrom
birkskyum:deprecate-h3-v1-syntax-in-createMiddleware

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 23, 2026

Re-deprecate h3 v1 middleware.

It's deprecated because we'd like people to use H3 v2 middleware instead, so we don't need the h3 v1 adapter etc

Mistakenly un-deprecated here:
9c479ee

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2026

⚠️ No Changeset found

Latest commit: 0d9ba53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 23, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 0d9ba53
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/699d7a3bc1ff3a0008b13936
😎 Deploy Preview https://deploy-preview-2082--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@birkskyum birkskyum changed the title Deprecate h3 v1 syntax in create middleware fix(v2): re-deprecate h3 v1 syntax in createMiddleware Feb 23, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 23, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2082
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2082

commit: 0d9ba53

Copy link
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

once we have the JSDoc updated and this PR merged, it would also be nice to communicate it to the docs via an issue linking to this PR too - not an immediate requirement though, can be done later - we have plenty of documentation to adjust

/**
* Creates middleware for handling requests and responses.
*
* @see https://docs.solidjs.com/solid-start/reference/server/create-middleware
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we deprecate the arguments, this docs entry is stale. We should not point users to it.

Co-authored-by: Atila Fassina <atilafassina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants