fix(v2): re-deprecate h3 v1 syntax in createMiddleware#2082
fix(v2): re-deprecate h3 v1 syntax in createMiddleware#2082birkskyum wants to merge 5 commits intosolidjs:mainfrom
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
atilafassina
left a comment
There was a problem hiding this comment.
thanks
once we have the JSDoc updated and this PR merged, it would also be nice to communicate it to the docs via an issue linking to this PR too - not an immediate requirement though, can be done later - we have plenty of documentation to adjust
| /** | ||
| * Creates middleware for handling requests and responses. | ||
| * | ||
| * @see https://docs.solidjs.com/solid-start/reference/server/create-middleware |
There was a problem hiding this comment.
once we deprecate the arguments, this docs entry is stale. We should not point users to it.
Co-authored-by: Atila Fassina <atilafassina@gmail.com>
Re-deprecate h3 v1 middleware.
It's deprecated because we'd like people to use H3 v2 middleware instead, so we don't need the h3 v1 adapter etc
Mistakenly un-deprecated here:
9c479ee