fix: Vite 8 compatible manifest plugin#2080
Open
birkskyum wants to merge 12 commits intosolidjs:mainfrom
Open
Conversation
🦋 Changeset detectedLatest commit: 5ca35c4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
birkskyum
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards
This PR contains:
solid-start:manifest-pluginto correctly resolve the client manifest during SSR builds under Vite 8 / Rolldown. It automatically detects the current major Vite version, and then:.vite/manifest.jsondirectly from theglobalThis.START_CLIENT_BUNDLEmemory footprint like before..solid-start/client/.vite/manifest.jsonfrom the filesystem, solvingundefined 'source'TypeErrors caused by changes to Rolldown'sgenerateBundleasset handling.