Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Gesture Handler Text wrapper component by renaming it to LegacyText and adjusting its implementation to remove forwardRef and add memoization for the native gesture instance, with the example app updated accordingly.
Changes:
- Renamed the exported component from
TexttoLegacyTextat the package entrypoint. - Reworked the
Textwrapper implementation (removedforwardRef, memoizedGesture.Native()instance). - Updated the “Nested Text” release test to use
LegacyText.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/index.ts | Renames the public export from Text to LegacyText. |
| packages/react-native-gesture-handler/src/components/Text.tsx | Reimplements the wrapper as LegacyText, changes ref handling approach, and memoizes the native gesture. |
| apps/common-app/src/legacy/release_tests/nestedText/index.tsx | Migrates the test example to import/use LegacyText. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR introduces 3 changes to
TextcomponentforwardedRefTest plan
Tested on "Nested Text" example