add pollHealthChecker interface for optional RPC health checks#83
Draft
Krish-vemula wants to merge 9 commits intomainfrom
Draft
add pollHealthChecker interface for optional RPC health checks#83Krish-vemula wants to merge 9 commits intomainfrom
Krish-vemula wants to merge 9 commits intomainfrom
Conversation
dhaidashenko
reviewed
Mar 3, 2026
| lggr.Tracew("Pinging RPC", "nodeState", n.State(), "pollFailures", pollFailures) | ||
| pollCtx, cancel := context.WithTimeout(ctx, pollInterval) | ||
| version, pingErr := n.RPC().ClientVersion(pollCtx) | ||
| if pingErr == nil { |
Contributor
There was a problem hiding this comment.
This is redundat with new logic, no?
multinode/node_lifecycle.go
Outdated
| } | ||
| lggr.Warnw("Finalized state not available", "err", stateErr, "failures", finalizedStateFailures, "threshold", finalizedStateCheckFailureThreshold) | ||
| if finalizedStateCheckFailureThreshold > 0 && finalizedStateFailures >= finalizedStateCheckFailureThreshold { | ||
| lggr.Errorw("RPC node cannot serve finalized state after consecutive failures", "failures", finalizedStateFailures) |
Contributor
There was a problem hiding this comment.
Let's introduce a metric similar to PollsFailed to have better visibility into the failure rate.
Add optional interface for chain-specific RPC clients to run extra health checks during alive-loop polling. Failures count toward poll failure threshold. Enables chain integrations to detect issues like missing historical state.
…r finalized state availability with configurable threshold and regex-based error classification.
Krish-vemula
force-pushed
the
cre/PLEX-2476
branch
from
72b9577 to
61b3d25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
PollHealthCheckmethod to theRPCClientinterface, enabling chain-specific RPC clients to perform additional health checks during node pool polling. Failures from this check count toward thePollFailureThreshold, allowing automatic detection and failover from unhealthy RPC nodes.Supports: #352