fix: error in ci when interactive inputs are required

[zimeg]

Changelog

Errors will appear sooner in CI and scripting setups if interactive input or a confirmation is requested. This guards against waiting until a timeout.

Summary

This PR fixes an error in CI when interactive inputs are required.

Preview

Login command

Update command

Reviewers

$ slack create | cat  # No change
$ slack login | cat   # Now errors
$ slack update | cat  # Now errors

Notes

• Some prompts don't have flag substitutes at this time but either might not have a required input or might need a flag option. This is saved for follow up PR but aligns more with the style guides:

slack-cli/.github/STYLE_GUIDE.md

Lines 16 to 22 in 5ee9e10

	### Prompts are Flags with Forms
	When information is needed we can prompt for text, confirmation, or a selection.
	These decisions can be made in an interactive terminal (TTY) or not, such as in a scripting environment.
	A flag option should exist for each prompt with a form fallback. Either default values should be used if forms are attempted in a non-TTY setup or an error and remmediation to use a flag should be returned.

• Hopes to address an initial issue of feat: Add flags for prompt values to upgrade command #87! 🏁

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[zimeg]

🦠 More comments to the kind reviewers!

[zimeg]

🔬 note: Here is the implementation of this function, with a default for no flags:

slack-cli/internal/iostreams/prompts.go

Lines 166 to 190 in 3215666

	// errInteractivityFlags formats an error for when flag substitutes are needed
	func errInteractivityFlags(cfg PromptConfig) error {
	flags := cfg.GetFlags()
	var remediation string
	var helpMessage = "Learn more about this command with `--help`"
	if len(flags) == 1 {
	remediation = fmt.Sprintf("Try running the command with the `--%s` flag included", flags[0].Name)
	helpMessage = "Learn more about this flag with `--help`"
	} else if len(flags) > 1 {
	var names []string
	for _, flag := range flags {
	names = append(names, flag.Name)
	}
	flags := strings.Join(names, "`\n `--")
	remediation = fmt.Sprintf("Consider using the following flags when running this command:\n `--%s`", flags)
	helpMessage = "Learn more about these flags with `--help`"
	}
	return slackerror.New(slackerror.ErrPrompt).
	WithDetails(slackerror.ErrorDetails{
	slackerror.ErrorDetail{Message: "The input device is not a TTY or does not support interactivity"},
	}).
	WithRemediation("%s\n%s", remediation, helpMessage)
	}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.09%. Comparing base (5ee9e10) to head (3215666).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   71.03%   71.09%   +0.05%     
==========================================
  Files         220      220              
  Lines       18522    18530       +8     
==========================================
+ Hits        13158    13173      +15     
+ Misses       4185     4178       -7     
  Partials     1179     1179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.