feat: env remove command supports the ".env" file for Bolt Framework apps#457
feat: env remove command supports the ".env" file for Bolt Framework apps#457
env remove command supports the ".env" file for Bolt Framework apps#457Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 70.96% 71.02% +0.05%
==========================================
Files 220 220
Lines 18466 18531 +65
==========================================
+ Hits 13105 13162 +57
- Misses 4183 4188 +5
- Partials 1178 1181 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Great work @zimeg! The design of this command is starting to showcase we how want all of our commands to be structure - linear flow in cmd/ with clean calls into internal/.
🧪 Manual test works well! I noticed removing an non-existent key will output success, which isn't wrong and reasonable for our first release!
| }, | ||
| })) | ||
| } else { | ||
| err := slackdotenv.Unset(clients.Fs, variableName) |
|
@mwbrooks Thanks so much for the review and thoughts to these changes! I'm also a fan of these command patterns and do hope it brings organization to other packages that we might want to untangle 🎁 Let's get this merged to complete Bolt support for these commands - I agree that follow up remains but I'm feeling alright with these changes overall 🌲 |
Changelog
Summary
This PR brings support for Bolt frameworks removing variables from the
.envfile with theenv removecommand! 🧾Follows #437 and #451 and #456 recent.
Preview
Reviewers
Use the various
envcommands to interact with this file:Notes
.envfile is now supported.env addbut might make sense?Requirements