fix: Empty user list for updating usergroup users sets usergroup as having no members#1574
Merged
vegeris merged 3 commits intoslackapi:mainfrom Mar 31, 2026
Conversation
|
Thanks for the contribution! Before we can merge this, we need @rozza-sb to sign the Salesforce Inc. Contributor License Agreement. |
…sers_sets_group_as_having_no_members
Contributor
|
Thanks for updating this and adding tests! |
vegeris
approved these changes
Mar 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1574 +/- ##
============================================
+ Coverage 73.17% 73.20% +0.03%
- Complexity 4510 4514 +4
============================================
Files 477 477
Lines 14283 14285 +2
Branches 1487 1488 +1
============================================
+ Hits 10451 10458 +7
+ Misses 2939 2936 -3
+ Partials 893 891 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when an empty list is provided within
UsergroupsUsersUpdateRequest, it is sent in the request asusers=, which is not supported by the Slack API to denote a usergroup as having 0 members. This adds a case for checking an empty list, and using the accepted value of[]in the request if so.Fixes #1573.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.