bug fix - combined mapped arg with blank string#231
Open
akashraghav wants to merge 1 commit intoskygragon:masterfrom
Open
bug fix - combined mapped arg with blank string#231akashraghav wants to merge 1 commit intoskygragon:masterfrom
akashraghav wants to merge 1 commit intoskygragon:masterfrom
Conversation
combined x.toString() result with blank string to avoid exception in case x is invalid/undefined, failing to call toString()
let s = args.map(x => x.toString()).join(' ');
^
TypeError: Cannot read properties of undefined (reading 'toString')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combined x.toString() result with blank string in log.js file line-55, to avoid exception in case x is invalid/undefined, failing to call toString().
should fix :
let s = args.map(x => x.toString()).join(' ');
------------------^
TypeError: Cannot read properties of undefined (reading 'toString')