feat: add optional support to respect the git ignorefile#527
Open
Kenneth-Sills wants to merge 2 commits intosemantic-release:masterfrom
Open
feat: add optional support to respect the git ignorefile#527Kenneth-Sills wants to merge 2 commits intosemantic-release:masterfrom
Kenneth-Sills wants to merge 2 commits intosemantic-release:masterfrom
Conversation
Per maintainer desire and to ensure backwards compatibility, this is disabled by default. Closes semantic-release#345 Closes semantic-release#347
|
@travi is there any way to get this reviewed and merged? That would be helpful |
achingbrain
added a commit
to ipld/js-dag-cbor
that referenced
this pull request
May 12, 2025
Turns out ignoring `.gitignore` while adding files to the release commit is a feature not a bug so specify the list of files to add. Refs: semantic-release/git#56 We can probably revert if semantic-release/git#527 ever gets merged.
rvagg
pushed a commit
to ipld/js-dag-cbor
that referenced
this pull request
May 20, 2025
Turns out ignoring `.gitignore` while adding files to the release commit is a feature not a bug so specify the list of files to add. Refs: semantic-release/git#56 We can probably revert if semantic-release/git#527 ever gets merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple flag configuration that controls whether the
gitcommands we run internally respect.gitignore(or whatevercore.excludesFileis set to), allowing downstream users to specify more broadassetssettings that are then restricted by the local ignore file.This is particularly useful when making shared configurations that, in my particular case, may need to perform last-minute file updates via the
postversionNPM lifecycle script that must be committed to the project repository (updating theversioninmanifest.jsonfor a browser extension).Based on maintainer opinion in #55 / #357 to avoid increasing maintenance burden and a desire to keep backwards compatibility, I've made sure this is an optional configuration option that defaults to being disabled.
Closes #345
Closes #347