Conversation
tothtamas28
approved these changes
Mar 21, 2026
Contributor
tothtamas28
left a comment
tothtamas28
left a comment
There was a problem hiding this comment.
LGTM.
I used an LLM to double-check and it found a few more typos, feel free to fix those as well if you have the time.
| set it is matching and N is the number of elements being matched. When it | ||
| appears on the left hand side containing variables not bound elsewhere in the | ||
| term, it is O(N^K) where N is the size of the set it is matching and K is the | ||
| number of unbound keys being mached. In other words, one unbound variable is |
|
|
||
| ### List elements | ||
|
|
||
| An element of a `List` is constucted via the `ListItem` operator. |
Contributor
There was a problem hiding this comment.
constucted -> constructed
| You can get an element of a list by its integer offset in O(log(N)) time, or | ||
| effectively constant. Positive `Int` indices are 0-indexed from the beginning of the | ||
| list, and negative indices are -1-indexed from the end of the list. In other | ||
| words, 0 is the first element and -1 is the last element. The indice can also be |
|
|
||
| You can create a new `List` which is equal to `dest` except the `N` elements | ||
| starting at `index` are replaced with the contents of `src` in O(N*log(K)) time | ||
| (where `K` is the size of `dest`and `N` is the size of `src`), or effectively linear. Having `index + N > K` yields an exception. |
Contributor
There was a problem hiding this comment.
`dest`and` -> `dest` and
| ### Bit slicing | ||
|
|
||
| You can compute the value of a range of bits in the twos-complement | ||
| representation of an integer, as interpeted either unsigned or signed, of an |
Contributor
There was a problem hiding this comment.
interpeted -> interpreted
| * Compute the natural logarithm `logFloat` of a float. | ||
| * Compute the sine `sinFloat` of a float. | ||
| * Compute the cosine `cosFloat` of a float. | ||
| * Compute the tangent `tanFlooat` of a float. |
| zero if it is not present. Finally, it is rounded to the nearest possible | ||
| value in a floating-point type represented like an IEEE754 floating-point type, | ||
| with the number of bits of precision and exponent specified by the suffix. | ||
| A suffix of `f` or `f` represents the IEEE `binary32` format. A suffix of `d` |
Contributor
There was a problem hiding this comment.
`f` or `f` -> `f` or `F`
|
|
||
| rule [eq-k-to-eq-int] : I1:Int ==K I2:Int => I1 ==Int I2 [simplification] | ||
| rule [eq-int-true-left] : {K1 ==Int K2 #Equals true} => {K1 #Equals K2} [simplification] | ||
| rule [eq-int-true-rigth] : {true #Equals K1 ==Int K2} => {K1 #Equals K2} [simplification] |
| rule [eq-int-true-left] : {K1 ==Int K2 #Equals true} => {K1 #Equals K2} [simplification] | ||
| rule [eq-int-true-rigth] : {true #Equals K1 ==Int K2} => {K1 #Equals K2} [simplification] | ||
| rule [eq-int-false-left] : {K1 ==Int K2 #Equals false} => #Not({K1 #Equals K2}) [simplification] | ||
| rule [eq-int-false-rigth] : {false #Equals K1 ==Int K2} => #Not({K1 #Equals K2}) [simplification] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some typos in domains.md that I thought I should fix: