Skip to content

Expand RDoc::Attr#dd_alias test cases for aliased attributes access types #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 1 commit into from
Feb 17, 2026
Merged

Expand RDoc::Attr#dd_alias test cases for aliased attributes access types #1612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions test/rdoc/code_object/attr_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,21 @@ def test_type
end

[
['bar', 'baz', 'R'],
['bar=', 'baz=', 'W']
].each do |original_name, new_name, expected_rw|
define_method("test_add_alias_#{new_name}_for_an_attribute_accessor") do
[{ rw: 'RW', type: :accessor }, { old_name: 'bar', new_name: 'baz' }, 'R'],
[{ rw: 'RW', type: :accessor }, { old_name: 'bar=', new_name: 'baz=' }, 'W'],
[{ rw: 'R', type: :reader }, { old_name: 'bar', new_name: 'baz' }, 'R'],
[{ rw: 'W', type: :writer }, { old_name: 'bar=', new_name: 'baz=' }, 'W']
].each do |orig_attr, an_alias, exp_rw|
define_method(
"test_add_alias_#{an_alias[:new_name]}_for_attr_#{orig_attr[:type]}_sets_correct_rw"
) do
context = RDoc::Context.new
attr = RDoc::Attr.new nil, 'bar', 'RW', ''
an_alias = RDoc::Alias.new nil, original_name, new_name, ''
attr = RDoc::Attr.new nil, 'bar', orig_attr[:rw], ''
als = RDoc::Alias.new nil, an_alias[:old_name], an_alias[:new_name], ''

new_attr = attr.add_alias an_alias, context
new_attr = attr.add_alias als, context

assert_equal expected_rw, new_attr.rw
assert_equal exp_rw, new_attr.rw
end
end
end