Ignore visibility method, attr definition, module_function within block

[tompng]

We need to ignore these within Module.new do end and any other block because it might be a metaprogramming block.

Ignoring def include extend in a block is already implemented. This pull request also make RDoc ignore visibility methods, attr definition and module_function in a block.

class A
  def f; end
  X = 1
  anonymous_module = Module.new do
    # These visibility change and attribute defition should be applied to anonymous module, but applied to A
    module_function :f
    private :f
    private_constant :X
    attr_accessor :rw
  end
end

Found while generating document in rails/rails
https://github.com/rails/rails/blob/45ee3bf84f20af55b8619b5dcc22a5e22a4ac0e7/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L307

module ColumnMethods
  class_methods do
    private
    def m; end # This is a private method of unknown class/module
  end

  def g; end # This method should be public, but was treated as private and not documented
end

[matzbot]

🚀 Preview deployment available at: https://a550c35f.rdoc-6cd.pages.dev (commit: 96f88d1)

[st0012]

Should the same check be added to visit_alias_method_node too?

[tompng]

Nice catch! Fixed

[st0012]

Not directly, related, but why does this method call yield here but _visit_call_public_private_protected calls it in a branch?

[tompng]

No specific reason. I think it's better to make it align.
If we're not calling yield (block is { super }) conditionally, calling super before calling this method is better.

I added this change:

_visit_call_public_private_class_method(args) { super }

def _visit_call_public_private_class_method(call_node, visibility)
  yield
  ...
end
# ↓
super
_visit_call_public_private_class_method(args)

def _visit_call_public_private_class_method(call_node, visibility)
  ...
end

[tompng]

tap do
  include A # in_proc_block = true
  tap do end # Exiting this block was making `@in_proc_block = false
  include B # in_proc_block was false, fixed to true
end