Remove pack parsing #3909
Open
Remove pack parsing #3909
+1
−1,371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
added a commit
to Earlopain/ruby
that referenced
this pull request
Feb 6, 2026
It was never adopted by ruby or other implementations. Ruyb 4.1 may add new directives, so now is a good time to remove it. It was actually never properly documented (just shows `Prism::Pack` with no methods) so removing seems safe to do even now. Ref * ruby/prism#3909 * ruby/prism#3907
Collaborator
Author
|
ruby/ruby#16085 to fix ruby CI, should be merged first. Looks like I won't do it after all. I asked in the bugtracker https://bugs.ruby-lang.org/issues/21839#note-7, let's see what happens with that. |
Member
|
There is a small typo in the commit message: |
Collaborator
|
Yeah this is good. We just need to merge it into CRuby first to make sure references to the headers and such go away. |
It was never adopted by ruby or other implementations. Ruby 4.1 may add new directives, so now is a good time to remove it. It was actually never properly documented (just shows `Prism::Pack` with no methods) so removing seems safe to do even now.
Earlopain
force-pushed
the
remove-pack
branch
from
9a1b505 to
9e57ba0
Compare
Earlopain
added a commit
to Earlopain/ruby
that referenced
this pull request
Feb 6, 2026
It was never adopted by ruby or other implementations. Ruby 4.1 may add new directives, so now is a good time to remove it. It was actually never properly documented (just shows `Prism::Pack` with no methods) so removing seems safe to do even now. Ref * ruby/prism#3909 * ruby/prism#3907
kddnewton
pushed a commit
to Earlopain/ruby
that referenced
this pull request
Feb 7, 2026
It was never adopted by ruby or other implementations. Ruby 4.1 may add new directives, so now is a good time to remove it. It was actually never properly documented (just shows `Prism::Pack` with no methods) so removing seems safe to do even now. Ref * ruby/prism#3909 * ruby/prism#3907
kddnewton
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 11, 2026
It was never adopted by ruby or other implementations. Ruby 4.1 may add new directives, so now is a good time to remove it. It was actually never properly documented (just shows `Prism::Pack` with no methods) so removing seems safe to do even now. Ref * ruby/prism#3909 * ruby/prism#3907
Collaborator
|
@Earlopain can you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was never adopted by ruby or other implementations. Ruby 4.1 may add new directives, so now is a good time to remove it.
It was actually never properly documented (just shows
Prism::Packwith no methods) so removing seems safe to do even now. I did a github code search and didn't find anyone using the ruby or c methods.I'll merge this if no changes are requested.
Closes #3907