fix: remove Py_single_input macro redefinition in PyMethodBase.h#21408
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Feb 27, 2026
Merged
Conversation
Remove the `#define Py_single_input 256` from the public header to avoid a `-Wmacro-redefined` warning when CPython's compile.h is included after the precompiled header already defines the macro. The default argument now uses the literal value with a comment.
Contributor
|
/backport to 6.36, 6.38 |
This was referenced Feb 27, 2026
|
This PR has been backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#define Py_single_input 256from the public headerPyMethodBase.hto avoid a-Wmacro-redefinedwarning when CPython'scompile.his included after the precompiled header already defines the macroPy_single_inputdefault argument inPyRunStringwith the literal value256and a commentFixes conda-forge/root-feedstock#342