Skip to content

Syntax lookup overhaul + add missing constructs#1204

Merged
fhammerschmidt merged 2 commits intomasterfrom
finish-syntax-lookup
Feb 27, 2026
Merged

Syntax lookup overhaul + add missing constructs#1204
fhammerschmidt merged 2 commits intomasterfrom
finish-syntax-lookup

Conversation

@fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Feb 26, 2026 •
edited
Loading

fixes #162
fixes #652
fixes #857 (the rest of it)
fixes #1121

image

@Bushuo
Copy link
Contributor

Bushuo commented Feb 26, 2026

@fhammerschmidt
could you please also rename the file decorator_non_undefined.mdx to decorator_not_undefined.mdx I mistakenly named it that way in the last PR

@github-actions
Copy link

github-actions bot commented Feb 26, 2026

Cloudflare deployment

Deployement ID: 240d7003-d13d-4f8b-b9f9-b102028852f4
Deployment Environment: preview

⛅️ wrangler 4.63.0 (update available 4.69.0)
─────────────────────────────────────────────
✨ Compiled Worker successfully
Uploading... (6722/7297)
Uploading... (6913/7297)
Uploading... (7105/7297)
Uploading... (7297/7297)
✨ Success! Uploaded 575 files (6722 already uploaded) (9.48 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://240d7003.rescript-lang.pages.dev
✨ Deployment alias URL: https://finish-syntax-lookup.rescript-lang.pages.dev

tsnobip
tsnobip approved these changes Feb 27, 2026
View reviewed changes
Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Florian doing God's work!
Thanks a lot! Some of those were looooong overdue!

markdown-pages/docs/manual/overview.mdx
Comment on lines +60 to 67
| JavaScript | ReScript |
| ----------- | -------- |
| `3` | Same \* |
| `3.1415` | Same |
| `3 + 4` | Same |
| `3.0 + 4.5` | Same |
| `5 % 3` | Same |

Copy link
Member

@tsnobip tsnobip Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so satisfying!!

@fhammerschmidt
Copy link
Member Author

fhammerschmidt commented Feb 27, 2026

I guess examples can be touched up a little more, but in a follow-up PR. Thanks for the review.

@fhammerschmidt fhammerschmidt merged commit ac9f32e into master Feb 27, 2026
5 checks passed
@fhammerschmidt fhammerschmidt deleted the finish-syntax-lookup branch February 27, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsnobip tsnobip tsnobip approved these changes

@zth zth Awaiting requested review from zth

@jderochervlk jderochervlk Awaiting requested review from jderochervlk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document new operators Rework module function documentation Add the "{..}" construct to syntax lookup Syntax Widget: Content Overview

3 participants

@fhammerschmidt @Bushuo @tsnobip