feat: allow configuring when to use the 'copy' dropEffect#3498
Open
TheUnlocked wants to merge 3 commits intoreact-dnd:mainfrom
Open
feat: allow configuring when to use the 'copy' dropEffect#3498TheUnlocked wants to merge 3 commits intoreact-dnd:mainfrom
TheUnlocked wants to merge 3 commits intoreact-dnd:mainfrom
Conversation
vlad00777
suggested changes
Oct 10, 2022
Comment on lines
40
to
51
| if (this.optionsArgs?.copyKey === undefined) { | ||
| return e.altKey | ||
| } | ||
| switch (this.optionsArgs?.copyKey) { | ||
| case 'shift': | ||
| return e.shiftKey | ||
| case 'ctrl': | ||
| return e.ctrlKey | ||
| case 'alt': | ||
| return e.altKey | ||
| case 'meta': | ||
| return e.metaKey |
There was a problem hiding this comment.
Suggested change
| if (this.optionsArgs?.copyKey === undefined) { | |
| return e.altKey | |
| } | |
| switch (this.optionsArgs?.copyKey) { | |
| case 'shift': | |
| return e.shiftKey | |
| case 'ctrl': | |
| return e.ctrlKey | |
| case 'alt': | |
| return e.altKey | |
| case 'meta': | |
| return e.metaKey | |
| switch (this.optionsArgs?.copyKey) { | |
| case 'shift': | |
| return e.shiftKey | |
| case 'ctrl': | |
| return e.ctrlKey | |
| case undefined: | |
| case 'alt': | |
| return e.altKey | |
| case 'meta': | |
| return e.metaKey |
Author
There was a problem hiding this comment.
It looks like this won't type check without a non-null assertion which is forbidden by the linter. Seems to be a TypeScript issue (minimal reproduction: https://www.typescriptlang.org/play?ts=4.9.0-dev.20221007#code/CYUwxgNghgTiAEYD2A7AzgF3gDwFzwG94AjWAfgAoBKfANyQEth4BfeAH3gFcVQAzBihDAA3ACg+PMBgap4fJEmqEx8NfDQB3BhjAALeBWxkAdKRhUV664ihoEPfoOG5VN93AxcYKcdZZuathmsNTiAUA).
There was an unnecessary optional chaining operator there though which I've removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows using keys other than alt to set the dropEffect to 'copy', and allows using a predicate callback in case the user wants more complex behavior.
Resolves #2979