Skip to content

fix: handle number 0 as valid label in SingleContent #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
Feb 13, 2026
+15 −1
Merged

fix: handle number 0 as valid label in SingleContent #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/SelectInput/Content/SingleContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ const SingleContent = React.forwardRef<HTMLInputElement, SharedContentProps>(
<div
className={clsx(
`${prefixCls}-content`,
displayValue && displayValue.label && `${prefixCls}-content-has-value`,
displayValue &&
displayValue.label !== null &&
displayValue.label !== undefined &&
displayValue.label !== '' &&
Comment on lines +92 to +94
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The condition to check for null and undefined can be simplified. Using the loose inequality operator != null checks for both null and undefined and is a common JavaScript idiom for this purpose. This makes the code more concise.

Suggested change
displayValue.label !== null &&
displayValue.label !== undefined &&
displayValue.label !== '' &&
displayValue.label != null && displayValue.label !== '' &&

`${prefixCls}-content-has-value`,
mergedSearchValue && `${prefixCls}-content-has-search-value`,
hasOptionStyle && `${prefixCls}-content-has-option-style`,
classNames?.content,
Expand Down
10 changes: 10 additions & 0 deletions tests/Select.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,16 @@ describe('Select.Basic', () => {
expect(container.querySelector('.rc-select-content-has-value')).toBeFalsy();
});

it('should add -content-has-value className when value is number 0', () => {
const { container } = render(
<Select value={0}>
<Option value={0}>0</Option>
<Option value="1">1</Option>
</Select>,
);
expect(container.querySelector('.rc-select-content-has-value')).toBeTruthy();
});

it('should default select the right option', () => {
const { container } = render(
<Select defaultValue="2">
Expand Down
Loading