Skip to content

Fix stack size flag for Clang/MSVC ABI builds#1380

Open
cronfox wants to merge 1 commit intoquickjs-ng:masterfrom
cronfox:master
Open

Fix stack size flag for Clang/MSVC ABI builds#1380
cronfox wants to merge 1 commit intoquickjs-ng:masterfrom
cronfox:master

Conversation

@cronfox
Copy link

@cronfox cronfox commented Mar 4, 2026

before:

[build] [1/1 100% :: 0.353] Linking C executable qjs.exe
[build] FAILED: qjs.exe 
[build] C:\WINDOWS\system32\cmd.exe /C "cd . && C:\PROGRA~2\MICROS~4\18\BUILDT~1\VC\Tools\Llvm\bin\clang.exe -nostartfiles -nostdlib -O0 -g -Xclang -gcodeview -D_DEBUG -D_DLL -D_MT -Xclang --dependent-lib=msvcrtd -Wl,--stack,8388608 -Xlinker /subsystem:console -fuse-ld=lld-link CMakeFiles/qjs_exe.dir/gen/repl.c.obj CMakeFiles/qjs_exe.dir/gen/standalone.c.obj CMakeFiles/qjs_exe.dir/qjs.c.obj -o qjs.exe -Xlinker /MANIFEST:EMBED -Xlinker /implib:qjs.lib -Xlinker /pdb:qjs.pdb -Xlinker /version:0.0   qjs-libc.lib  qjs.lib  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 -loldnames  && cd ."
[build] lld-link: warning: ignoring unknown argument '--stack'
[build] lld-link: error: could not open '8388608': no such file or directory
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)

now: success building

@saghul
Copy link
Contributor

saghul commented Mar 4, 2026

Any chance we can add that those CI? We don't seem to have that one covered.

@saghul
Copy link
Contributor

saghul commented Mar 4, 2026

Oh and I guess we also need this for Meson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants