Fix local extension override for typst book format#14332
Open
gordonwoodhull wants to merge 1 commit intomainfrom
Open
Fix local extension override for typst book format#14332gordonwoodhull wants to merge 1 commit intomainfrom
gordonwoodhull wants to merge 1 commit intomainfrom
Conversation
When a user explicitly specifies `format: orange-book-typst` in a book project, prefer a locally installed copy of the extension over the built-in one, so customizations take effect. The default behavior for `format: typst` (which auto-assigns orange-book) is unchanged. Adds a `preferLocal` flag threaded through the extension lookup chain that, when set, checks local `_extensions/` before built-in extensions. Only the explicit typst book extension case sets this flag. Fixes #14326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format: orange-book-typstin a book project and has a locally installed copy of the extension, the local copy is now used instead of the built-in oneformat: typstin book projects continues to use the built-in orange-book as the defaultpreferLocalflag threaded through the extension lookup chain (ExtensionContext.extension()→loadExtension()→discoverExtensionPath()), defaulting tofalseso all other extension resolution is unchangedTest plan
tests/docs/smoke-all/typst/override-orange-book/verifies local extension'stypst-show.typis used whenformat: orange-book-typstis explicittests/docs/smoke-all/typst/orange-book/tests pass (no regression forformat: typstdefault)Fixes #14326