fix(typst): add rendering for proof, remark, and solution environments#14312
Open
mcanouil wants to merge 2 commits intoquarto-dev:mainfrom
Open
fix(typst): add rendering for proof, remark, and solution environments#14312mcanouil wants to merge 2 commits intoquarto-dev:mainfrom
mcanouil wants to merge 2 commits intoquarto-dev:mainfrom
Conversation
…quarto-dev#14290) The Proof renderer lacked a Typst-specific branch, causing remark and solution environments to fall through to the generic renderer which produces plain `#block[...]` output that Typst cannot cross-reference. Add a Typst branch that generates proper theorion `make-frame()` calls with labels, matching how theorem environments already work. Extract shared theorion setup logic into `common/theorems.lua` to avoid duplication between theorem.lua and proof.lua. Closes quarto-dev#14290
…variable limit The import()-based common/theorems.lua added locals to the main chunk scope, pushing past Lua's 200-variable limit and breaking CI. Move the logic to modules/theorems.lua loaded via require(), which runs in its own scope.
mcanouil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14290.
The
Proofrenderer lacked a Typst-specific branch, soremarkandsolutionenvironments fell through to the generic renderer producing#block[...]output that Typst cannot cross-reference.Adds a Typst branch that generates theorion
make-frame()calls with labels, matching how theorem environments already work.Extracts shared theorion setup logic into
common/theorems.luato avoid duplication betweentheorem.luaandproof.lua.The shared content was moved to a module to workaround the Lua bundle limit.