Conversation
d5dc015 to
c5a2169
Compare
|
@cderv I'm pushing this to v1.8 but feel free to move back to v1.7 if you've made the changes we talked about last week. |
c5a2169 to
45c8580
Compare
|
I rebased - this is where I was. |
|
Right - we had talked about using |
Yeah I used more verbose env var name because I feel those two are too generic... We are in It does not apply to A border topic.
I have done that part by removing the Let's continue in 1.8 then. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
d5ef878 to
b884232
Compare
0cbf1a7 to
79b6a54
Compare
This will allows scripts to be quiet
which seems a better way to take into account `quiet` option in addition to progress.
Use args.slice(1) instead of args.splice(1) to avoid unnecessary array mutation. Add changelog entry for new env vars and logging.
79b6a54 to
3335dc3
Compare
This is an idea coming from work on quarto-dev/quarto-web#1612
Logging improvement
The logging was not completely explicit as it was showing only the script name without context. This PR adds a
Running scriptprefix:New environment variables
Two new environment variables are set for pre/post render scripts so they can adapt their output:
QUARTO_PROJECT_SCRIPT_PROGRESS—"1"when progress can be shown,"0"otherwiseQUARTO_PROJECT_SCRIPT_QUIET—"1"when--quietflag is active,"0"otherwiseprogressis true when rendering multiple files or when explicitly requested via options.Refactoring
The handler/non-handler code paths in
runScriptswere consolidated using a default handler with nullish coalescing (??), eliminating duplicated logic. Environment initialization was also moved before the loop, fixing a pre-existing issue where the non-handler branch didn't copy the caller'senv.