gh-140715: Add %t format code support to strptime()#144896
Open
jyalim wants to merge 5 commits intopython:mainfrom
Open
gh-140715: Add %t format code support to strptime()#144896jyalim wants to merge 5 commits intopython:mainfrom
jyalim wants to merge 5 commits intopython:mainfrom
Conversation
4 tasks
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
This is quite an odd case, as per the standard for strftime, it is a \t character, however, for strptime():
And, more straightforward:
Considering that this is the wide-spread behaviour, it should instead be r'\s+' for %n/%t (with additional tests), and add a note to the doc.
|
|
||
| .. versionadded:: 3.15 | ||
| ``%:z``, ``%F``, and ``%D`` were added for :meth:`~.datetime.strptime`. | ||
| ``%:z``, ``%F``, ``%D``, and ``%t`` were added for |
Member
There was a problem hiding this comment.
Please sort them alphabetically, this list is getting long now.
| test_date = "2026\t02\t16" | ||
| self.assertEqual( | ||
| self.theclass.strptime(test_date, "%Y%t%m%t%d"), | ||
| self.theclass.strptime(test_date, "%Y\t%m\t%d") |
Member
There was a problem hiding this comment.
Here, I would prefer we explicitly have self.theclasss(2026, 2, 16).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incrementally builds C99+ datetime support with addition of
%twith single line of code. Also adds tests and updates documentation.Continued effort from PR: #140647 , #144819.
Documentation drops (0) footnote.
Passed all tests.
Passed patchcheck.
Issue: #140715
str*timeto C11 format codes #140715📚 Documentation preview 📚: https://cpython-previews--144896.org.readthedocs.build/