gh-138912: Add fast path for match class patterns without sub-patterns#144820
Open
cdce8p wants to merge 1 commit intopython:mainfrom
Open
gh-138912: Add fast path for match class patterns without sub-patterns#144820cdce8p wants to merge 1 commit intopython:mainfrom
cdce8p wants to merge 1 commit intopython:mainfrom
Conversation
aa2f4a9 to
8cfaa01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #139080. This builds on the work merged with 75d4839.
Add a fast path for match class patterns without any sub-patterns. This avoids creating a new (empty) tuple, pushing it to the stack and subsequently unpacking the tuple result from the
MATCH_CLASSopcode again.__
Micro benchmarks with all specializations enabled.
Micro benchmark (bare class pattern)
If specialization disabled, the performance improvement is even better with -40.5%.
📚 Documentation preview 📚: https://cpython-previews--144820.org.readthedocs.build/