gh-69605: Add math.integer to PyREPL module completer hardcoded list#144811
Open
loic-simon wants to merge 4 commits intopython:mainfrom
Open
gh-69605: Add math.integer to PyREPL module completer hardcoded list#144811loic-simon wants to merge 4 commits intopython:mainfrom
loic-simon wants to merge 4 commits intopython:mainfrom
Conversation
loic-simon
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
johnslavik
approved these changes
Feb 14, 2026
johnslavik
reviewed
Feb 14, 2026
Misc/NEWS.d/next/Core_and_Builtins/2026-02-14-13-07-08.gh-issue-69605.4aL4hn.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new
math.integersubmodule to the hardcoded list of stdlib modules that cannot be detected bypkgutil(implemented in #138268).See this DPO post for more context about why this is necessary in the first place. I also talk about a new test to ensure this list doesn't get more out of sync, but it builds on the work I did in #140871 (to ensure we don't import a "dangerous" module), so I'll propose it after that MR is merged.
I don't think this change needs a specific issue, but happy to do create one if needed!