GH-138800: fix variable substitution in python3.pc for Android#144776
GH-138800: fix variable substitution in python3.pc for Android#144776thunder-coding wants to merge 1 commit intopython:mainfrom
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@thunder-coding if you do not want to sign the CLA with CLA bot you can fill out the form here: https://www.python.org/psf/contrib/contrib-form/ You could also use the bot and revoke the permissions afterwards. It is open source: https://github.com/psf/clabot |
b134b12 to
e30a3cf
Compare
e30a3cf to
c3820e4
Compare
$(BLDLIBRARY) substitution works in Makefiles where variables are expanded at the time of execution. This expansion does not happen in static files like .pc, so use value of BLDLIBRARY instead of trying to substitute the value. Patch stolen from downstream distribution of Python for Termux (Android): termux/termux-packages#27739 Preferably needs to be backported to both Python 3.13 as well as Python 3.14, along with the main branch Fixes python#138800
c3820e4 to
8ec582a
Compare
|
Oops, looks like I did a rebase which has managed to pinged a lot of people. Apologies for the mess I created. I can start up with another PR in order to reduce the spam I unintentionally created. And I've signed the CLA on https://www.python.org/psf/contrib/contrib-form/, but doesn't seem to have been updated here yet |

$(BLDLIBRARY) substitution works in Makefiles where variables are expanded at the time of execution. This expansion does not happen in static files like .pc, so use value of BLDLIBRARY instead of trying to substitute the value.
Patch stolen from downstream distribution of Python for Termux (Android): termux/termux-packages#27739
Preferably needs to be backported to both Python 3.13 as well as Python 3.14, along with the main branch
Fixes #138800