Speed up flake8-async by telling libcst to skip deepcopy.#438
Open
yilei wants to merge 2 commits intopython-trio:mainfrom
Open
Speed up flake8-async by telling libcst to skip deepcopy.#438yilei wants to merge 2 commits intopython-trio:mainfrom
yilei wants to merge 2 commits intopython-trio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? The default
deepcopyinlibcstguards against the same CST node object appearing at two positions in the tree (metadata is keyed by node identity). In our use of libcst in flake8-async, the parser output and the result of a prior.visit()never share nodes, so the copy is wasted work. This stays safe as long as no visitor returns a cached CST node from multipleleave_*calls.See
pyref.dev/libcst.metadata.MetadataWrapper.__init__Running the flake8-async tests on my machine now takes
29.81sinstead of38.95swith this change.