Mark yield_fixture as deprecated

[MarcoGorelli]

yield_fixtureis deprecated, is it ok to use thedeprecated` decorator on it?

pytest/src/_pytest/fixtures.py

Lines 1434 to 1435 in 959cd47

	.. deprecated:: 3.0
	Use :py:func:`pytest.fixture` directly instead.

[bluetech]

Thanks, however the hitch here is that @deprecated also emits a runtime warning, so with this we will be emitting 2 runtime deprecation warnings. You could say, let's remove the existing runtime deprecation, the problem with that is that our compat for Python < 3.13 doesn't emit a runtime warning. This has been fine so far since we only use @deprecated under TYPE_CHECKING, but here it's not.

So either

• We backport @deprecated runtime behavior. But the Python code is about a 100 lines, a bit too much I think.
• We move the @deprecated under TYPE_CHECKING (duplicating def yield_fixture), that's a bit ugly though.
• We leave as is for now.

[bluetech]

Let's use the same text as the existing runtime deprecation.

Suggested change

	"pytest.yield_fixture is deprecated, use pytest.fixture to access configuration values instead.",
	"@pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same.",

[MarcoGorelli]

thanks for your response!

We leave as is for now.

sure, happy to do this!

[The-Compiler]

I'd go for (trivial) option 4: Pass category=None into warnings.deprecated() so that it doesn't show a runtime warning, and keep our own.

I think there is a lot of value in having deprecations visible statically, so I opened #14342 to that effect.

Thanks @MarcoGorelli for getting the ball rolling!