Make FixtureFuction type alias instead of TypeVar#14339
Merged
bluetech merged 2 commits intopytest-dev:mainfrom Mar 30, 2026
Merged
Make FixtureFuction type alias instead of TypeVar#14339bluetech merged 2 commits intopytest-dev:mainfrom
bluetech merged 2 commits intopytest-dev:mainfrom
Conversation
de87692 to
aaf9ab4
Compare
aaf9ab4 to
a961889
Compare
bluetech
approved these changes
Mar 30, 2026
changelog/14399.misc.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Made ``FixtureFunction`` a type alias instead of a type var, as it only ever appears once in any function signature. | |||
Member
There was a problem hiding this comment.
Since this is not a user-visible change we can skip the changelog, I added skip-news label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixtureFunctiononly appears twice:pytest/src/_pytest/fixtures.py
Line 1241 in 0e2846f
pytest/src/_pytest/fixtures.py
Lines 1344 to 1352 in 0e2846f
Both times, it only appears once in a function signature. Therefore, the
TypeVarhas no effectpyright would warn about this too: