Schedule deprecated legacy hook marks for removal in pytest 10#14335
Merged
bluetech merged 1 commit intopytest-dev:mainfrom Mar 31, 2026
Merged
Schedule deprecated legacy hook marks for removal in pytest 10#14335bluetech merged 1 commit intopytest-dev:mainfrom
bluetech merged 1 commit intopytest-dev:mainfrom
Conversation
nicoddemus
approved these changes
Mar 29, 2026
RonnyPfannschmidt
approved these changes
Mar 30, 2026
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
Might want to add a changelog as this one is now sheduled
By the time pytest 10 is released, this will have been deprecated for more than 5 years (0fdacb6), and the alternative syntax available for over 10 years (d2a5c7f), which seems like enough time. Removal will simplify PytestPluginManager and leave us with one way for setting hookspec/hookimpl options (the plan after removal is to just treat the old markers as normal markers, not hard-error on them).
bluetech
force-pushed
the
sched-rm-legacy-hook-marks
branch
from
3de823b to
bf9977f
Compare
bluetech
removed
the
skip news
psf-chronographer
bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the time pytest 10 is released, this will have been deprecated for more than 5 years (0fdacb6), and the alternative syntax available for over 10 years
(d2a5c7f), which seems like enough time.
Removal will simplify PytestPluginManager and leave us with one way for setting hookspec/hookimpl options (the plan after removal is to just treat the old markers as normal markers, not hard-error on them).