ModelChain model variation example to system-models
#2691
Conversation
|
this PR is not complete yet! |
| ax.set_title("Comparison of Temperature Models") | ||
| ax.legend() | ||
| plt.tight_layout() | ||
|
|
There was a problem hiding this comment.
The figures aren't appearing. Do you need to add plt.show()?
There was a problem hiding this comment.
added plt.show() so that the figures are displayed
also updated the example to use the correct temperature model parameters for each model and set aoi_model="no_loss" to avoid inference issues with the minimal PVWatts setup
There was a problem hiding this comment.
Figures still don't show. Are you sure they are being created when you run this locally?
There was a problem hiding this comment.
i am getting this when running locally
There was a problem hiding this comment.
should i change the title from Comparison of Temperature Models to Variations?
| ) | ||
|
|
||
| weather_subset = pd.DataFrame({ | ||
| "ghi": 800, |
There was a problem hiding this comment.
I think it would be better to generate use clear-sky irradiance, and non-constant air temperature, which you can make up.
There was a problem hiding this comment.
i am looking into this, will push the updated commit shortly!
| 'examples_dirs': ['../../examples'], # location of gallery scripts | ||
| 'gallery_dirs': ['gallery'], # location of generated output | ||
| # execute all scripts except for ones in the "system-models" directory: | ||
| 'filename_pattern': '^((?!system-models).)*$', |
There was a problem hiding this comment.
@kandersolar are you OK with this change to the sphinx configuration for the example gallery?
There was a problem hiding this comment.
maybe 'filename_pattern': '^((?!system-models).)*$', was added so as to not execute the oedi example which is in system-models
so i have preserved the same logic of not executing that example, but to execute the new added example plot_modelchain_model_variations.py, so that the figures are rendered.
2 participants
ModelChaintemperature comparison example tosystem-models#2689docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR adds a new Sphinx-gallery example under
docs/examples/system-modelsthat demonstrates how to vary models within aModelChaincalculation.