-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix swapped reference numbering in get_bsrn docstring
#2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swapped reference numbering in get_bsrn docstring
#2680
Conversation
|
thanks @aman-coder03 ! |
|
@aman-coder03 @cwhanse ups...
|
|
Derp. [2] and [4] are reversed. Thank you @ramaroesilva |
|
oops!😅 |
|
|
@ramaroesilva I looked again. I think the reference order is now correct in |
|
It is somewhat confusing that all three BSRN functions cite the same 4 references, but in a different order that conforms to each function's docstring. |
|
i fixed the order like it was in the screenshot in the #2681 |
|
@cwhanse, sorry my bad. this printscreen was actually from to me, |
|
@ramaroesilva be sure to check https://pvlib-python.readthedocs.io/en/latest/ instead of https://pvlib-python.readthedocs.io/en/stable/. |
|
Thanks @kandersolar! Always learning new things :-) @aman-coder03, looks great now! |

docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The order of references was correct, but labels [3] and [4] were interchanged.